Nits: live path $config null handling; stale .gitignore comment #10

New issue

Closed

opened 2026-10-18 17:14:42 -07:00 by eric · 0 comments

eric commented

2026-10-18 17:14:42 -07:00

Owner

Severity: Nit

10-wancarp:378, 410: the live run passes $config straight into an array-typed parameter of resolve_iface(), while dry-run uses $config ?? []. If $config is null, the live run logs an unhelpful TypeError through the catch block instead of the clear "config not populated" message. Use $config ?? [] (or an explicit check) in the live path too.
.gitignore: the comment says the file is "Generated per-release by release.sh", but there is no release.sh; .forgejo/workflows/release.yml does this. Update the comment.

**Severity:** Nit - **`10-wancarp:378`, `410`:** the live run passes `$config` straight into an `array`-typed parameter of `resolve_iface()`, while dry-run uses `$config ?? []`. If `$config` is null, the live run logs an unhelpful TypeError through the catch block instead of the clear "config not populated" message. Use `$config ?? []` (or an explicit check) in the live path too. - **`.gitignore`:** the comment says the file is "Generated per-release by release.sh", but there is no `release.sh`; `.forgejo/workflows/release.yml` does this. Update the comment.

eric added the

enhancement

label

2026-10-18 17:14:42 -07:00

eric referenced this issue from a commit

2026-10-20 09:45:26 -07:00

fix: guard the live path against a null $config; correct .gitignore comment

eric closed this issue

2026-10-20 09:45:26 -07:00