remove_backup_route: route repoint is one-way and gated on $changed #6

New issue

Closed

opened 2026-10-18 17:14:41 -07:00 by eric · 0 comments

eric commented

2026-10-18 17:14:41 -07:00

Owner

Severity: Medium (only when $remove_backup_route = true) · Location: 10-wancarp:444-452, MASTER branch 375-405

No restore on MASTER. The MASTER branch never undoes the default-route repoint to $lan_vip. It relies on interface_configure → newwanip to rewrite the default route. That probably works with DHCP, but I couldn't confirm it for a static WAN. If it doesn't happen, the new MASTER sends its default traffic to the peer, which is now the BACKUP with its WAN down.
Repoint skipped when WAN was already down. The repoint only runs when $changed is true. If WAN was already down (for example it failed to come up at boot), the BACKUP keeps a stale or missing default route.
Errors are ignored. If route delete default fails, its error is logged and route add runs anyway.

Suggested fix:

Explicitly restore the default route (or trigger routing reconfigure) on MASTER when $remove_backup_route is set.
Decide the repoint based on the current default route, not on $changed.
Check run_cmd() results.

**Severity:** Medium (only when `$remove_backup_route = true`) · **Location:** `10-wancarp:444-452`, MASTER branch `375-405` - **No restore on MASTER.** The MASTER branch never undoes the default-route repoint to `$lan_vip`. It relies on `interface_configure` → newwanip to rewrite the default route. That probably works with DHCP, but I couldn't confirm it for a static WAN. If it doesn't happen, the new MASTER sends its default traffic to the peer, which is now the BACKUP with its WAN down. - **Repoint skipped when WAN was already down.** The repoint only runs when `$changed` is true. If WAN was already down (for example it failed to come up at boot), the BACKUP keeps a stale or missing default route. - **Errors are ignored.** If `route delete default` fails, its error is logged and `route add` runs anyway. **Suggested fix:** - Explicitly restore the default route (or trigger routing reconfigure) on MASTER when `$remove_backup_route` is set. - Decide the repoint based on the current default route, not on `$changed`. - Check `run_cmd()` results.

eric added the

bug

label

2026-10-18 17:14:41 -07:00

eric referenced this issue from a commit

2026-10-20 09:01:33 -07:00

fix: make the remove_backup_route repoint two-way and state-driven

eric closed this issue

2026-10-20 09:01:33 -07:00

eric referenced this issue

2026-10-20 09:37:05 -07:00

Pre-release live HA test plan #11