END banner reports result=ok even when run_cmd() fails #7

New issue

Closed

opened 2026-10-18 17:14:41 -07:00 by eric · 0 comments

eric commented

2026-10-18 17:14:41 -07:00

Owner

Severity: Low · Location: 10-wancarp:429, 448-450, 493

The return value of run_cmd() is ignored. If ifconfig down or a route command fails, an error line is logged, but the END banner still says result=ok changed=yes. Anyone scanning END banners will miss the failure.

Suggested fix: track a $failed flag from run_cmd() results and report result=partial (or similar) in the END banner. Update the README's banner description to match.

**Severity:** Low · **Location:** `10-wancarp:429`, `448-450`, `493` The return value of `run_cmd()` is ignored. If `ifconfig down` or a route command fails, an error line is logged, but the END banner still says `result=ok changed=yes`. Anyone scanning END banners will miss the failure. **Suggested fix:** track a `$failed` flag from `run_cmd()` results and report `result=partial` (or similar) in the END banner. Update the README's banner description to match.

eric added the

bug

label

2026-10-18 17:14:41 -07:00

eric referenced this issue from a commit

2026-10-20 09:30:43 -07:00

fix: report result=partial in the END banner when an action fails

eric closed this issue

2026-10-20 09:30:43 -07:00

eric referenced this issue

2026-10-20 09:37:05 -07:00

Pre-release live HA test plan #11