MASTER idempotency guard trusts UP flag alone #8

New issue

Closed

opened 2026-10-18 17:14:41 -07:00 by eric · 0 comments

eric commented

2026-10-18 17:14:41 -07:00

Owner

Severity: Low · Location: 10-wancarp:390

The MASTER check skips any interface whose UP flag is set. If an earlier BACKUP run threw partway through, or someone ran ifconfig <dev> up by hand, the interface is UP but has no IP or DHCP client. MASTER then logs "already up, skipping" and the promoted node has no working WAN.

This is rare, but it is the one way the idempotency check reports a false OK.

Suggested fix: also require a configured address on the interface (e.g. an inet line, or get_interface_ip() non-empty) before skipping.

**Severity:** Low · **Location:** `10-wancarp:390` The MASTER check skips any interface whose UP flag is set. If an earlier BACKUP run threw partway through, or someone ran `ifconfig <dev> up` by hand, the interface is UP but has no IP or DHCP client. MASTER then logs "already up, skipping" and the promoted node has no working WAN. This is rare, but it is the one way the idempotency check reports a false OK. **Suggested fix:** also require a configured address on the interface (e.g. an `inet` line, or `get_interface_ip()` non-empty) before skipping.

eric added the

bug

label

2026-10-18 17:14:41 -07:00

eric referenced this issue from a commit

2026-10-20 09:35:16 -07:00

fix: require an address or DHCP client before MASTER skips an UP interface

eric closed this issue

2026-10-20 09:35:16 -07:00

eric referenced this issue

2026-10-20 09:37:05 -07:00

Pre-release live HA test plan #11